Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

QR code card component using CSS

react, react-native, sass/scss, styled-components
isayaexavery•10
@isayaexavery
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


First I wanted to the project with bootstrap then I decided to do it with plane CSS. Your feedback will be very much appreciated.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Chris Andrews•170
    @ChrisAndrewsDev
    Posted almost 3 years ago

    Hey @isayaexavery, nice work on your first challenge!

    There's a few small HTML warnings that are easy to remedy:

    • Using semantic landmark HTML tags <main> <section> in place of standard <div> tags to divide sections is best practice and helps with accessibility for screen-readers.
    • You typically want to start with an <h1> on a page and work your way down to smaller headings for less vital content: <h1> to <h2> to <h3> and so on.

    One small thing I noticed when compared to the design brief is that your paragraph should be text-align: center

    You should definitely look into custom CSS variables if you're working with vanilla CSS, especially when doing the challenges here, they make life so much easier when working from a design brief!

    Other than that, your CSS was solid, I could see you experimented with some styles and methods to get a preferred outcome, there are a couple of smaller tweaks I would have made, but you're on the right track for sure!

    Nice one!

    Marked as helpful
  • Lucas 👾•104,160
    @correlucas
    Posted almost 3 years ago

    👾Hello Isayaexavery, congratulations for you challenge solution!

    I just saw your live site and I've some tips for you about the design and the elements.

    1.The container text should be aligned to center not to left, use text-align: center;. 2.The H1 font-size is a little bit bigger, you can also switch from h3 to h1. 3.The border-radius for the qrcode image is a little bit different for the container border-radius due some design proportions the inner border-radius should be ever a little bit smaller from the outer content.

    I wrote you the code fixes below:

        text-align: center;
        width: 32rem;
        margin: 10rem auto;
        padding: 2.4rem 0;
        display: flex;
        /* justify-content: center; */
        /* align-items: center; */
        flex-direction: column;
        gap: 2rem;
        background-color: hsl(0, 0%, 100%);
        border-radius: 12px;
    }
    
    .card-content h3 {
        font-size: 2.25rem;
        color: hsl(218, 44%, 22%);
    }
    
    .card-img {
        border-radius: 10px;
    }
    
    

    Hope it helps you, happy coding bro!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub