QR code card component with html & css

Solution retrospective
Hello everyone.
I am a beginner in these challenges for frontend development.
I would like to know after this practice:
-
How can I improve as far as clean code is concerned?
-
What kind of mistakes should I not make?
-
Any difficulties that you had when carrying out this project?
I appreciate your comments and I will take them into account to improve the next times.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @0xabdulkhaliq
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HEADINGS ⚠️:
- This solution consists incorrect usage of
<h2>
so it can cause severe accessibility errors due to incorrect usage of level-two headings<h2>
- Every site must want only one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- In this solution there's
<h2>
element which is this<h2>Improve your...</h2>
, you can preferably use<h1>
instead of<h2>
. Remember<h1>
provides an important navigation point for users of assistive technologies so we want to use it wisely
- So we want to add a level-one heading to improve accessibility
- Example:
<h1>Improve your front-end skills by building projects</h1>
- If you have any questions or need further clarification, and feel free to reach out to me.
- If you have any questions or need further clarification, you can always check out
my submission
and/or feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful - @vivekrajput-93
Well done brother, u did good , but I would prefer the appyling the font-family which is given in the instruction, cos it perfectly match with component, over all looks great to me.
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord