Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Qr Code Card

@Xermelly

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@vjeanty02

Posted

Hello @Xermelly, You did a good job on your challenge

Howerver, I have the following to say:

  • It is important to always create a readme file in your repository Try to maintain a clean repository using GitHub best practices. For more information see the following link : best-practices-for-projects
  • Then you need to add the right colors to your title and your paragraph in the css code. Try to name your classes and variables so that other developers can read them. Instead of saying c1, c2, c3 for colors, preferably use color-primary, color-secondary, color-tertiary. -If you're having trouble naming your CSS classes, see the following link : Google HTML/CSS Style Guide. Otherwise, you can use the BEM methodology. See the following link for more information : BEM

I really enjoyed reading your code. Regards.

Marked as helpful

0

@Xermelly

Posted

@vjeanty02 Thanks for the tips, I'll take a look at the content you sent, and I'll correct a few things, thanks!!!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord