Submitted almost 3 years ago

QR Code Challenge

@popmatic

A solution to the QR code component challenge

Solution retrospective

This was just a warm up with frontend mentor...to get used to the process and to figure out github, which confuses me to no end.

My co-worker submitted his solution last night, and I understand that people came back with suggestions on making the code more semantic. I will definitely focus on that more next time.

Code

Please log in to post a comment

Community feedback

Lucas 👾•104,160
@correlucas
Posted almost 3 years ago
👾Hi @popmatic, congratulations on your first solution!👋 Welcome to the Frontend Mentor Coding Community!

Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

1.Replace the <h2> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.

2.Reduce your code by removing unnecessary elements. The HTML structure is working but you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.
```
<body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>
```
✌️ I hope this helps you and happy coding!
Marked as helpful
Aecio Neto•340
@aecio-neto
Posted almost 3 years ago
Hi, Troy. Congratulations on completing the project. It looks great!

Here are some considerations:

Indentation and space in code - a good practice is to organize your code more readable. You can eliminate some empty spaces inside your html and css.

As you already said, semantic html (main, article) will make your code better. Just replace and/or delete some divs.

Also, it is possible to replace the h2 with an h1, since it is the only and main title of the page.

Your page takes up more than the first fold, you can make it smaller and eliminate scrolling. This would improve usability.

Hope this helps.
Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord