Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code challenge

Billehβ€’ 10

@scegob

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This was my first time following along to a style guide, it gave me great practice with following along with it it. I would like to get more done with mobile first design. The area I was unsure of was to get it more to the center but it is

Community feedback

Tesla_Ambassadorβ€’ 2,980

@tesla-ambassador

Posted

Hey Billeh, congratulations on completing this challenge! I hope you enjoyed taking it on 😎 Here's a few tips to help you completely annihilate this challenge πŸ’₯ :

  • I noticed that you used display flex on your body element and it flexed your attribution div and the card component in a horizontal direction. In order to fix those issues, you might want to add the following styles to your body.
body {
    flex-direction: column;
    justify-content: center;
    gap: 20px;
}

Just add them, it will center your card and let your items be flexed in a horizontal direction.

  • In order to resolve some of your accessibility issues, you might wanna use landmarks in your html code, these help browsers easily navigate your code. So you might consider wrapping your divs in landmarks like <main> or <header> or <footer> you need to do this according to how your page is structured. Incase you want to know more about landmarks, follow this link.

Happy coding and keep up the good work!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord