QR code challenge

Community feedback

• 

  Hassia Issah•50,410

  @Hassiai

  Posted about 2 years ago

  Replace <div class="container"> with the main tag to make the page/content accessible. click here for more on web-accessibility and semantic html

  Add the alt attribute alt=" " to the img tag and give it a value. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.

  The body has a wrong background-color. give it a background-color of light-gray. Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

  there is no need to style .container, To center .card on the page using flexbox or grid, dd min-height:100vh; display: flex; align-items: center: justify-content: center; to the body OR add min-height:100vh; display: grid place-items: center to the body

  • USING FLEXBOX:

  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  • USING GRID:

  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  For a responsive content,

  • Replace the width in .card with max-width and increase its value max-width: 320px which is 20rem/em

  Give h1 and p text-align: center, the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  00