Skip to content
Submitted almost 3 years ago

Qr code challenge with css flexbox

Mohammed-Abol-Fotouh•80
@Mohammed-Abol-Fotouh
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

this is my solution for the QR code challenge please review my solution and tell me if there is best practice should i follow thanks in advance

Code

Please log in to post a comment

Log in

Community feedback

  • Shann Timothy•160
    @ShannTimothy22

    Congratulation on finishing the challenge 🥳 , your solution looks great and there's no accessibility issues and html issues, I have some few suggestion

    • The container seems to have fixed height, it makes your content overflowing you can fix that by removing the fixed height

    • It also seems there’s a few problem with some of the breakpoints (responsiveness), you can fix the problem by simply adding more breakpoint

    • For the padding and margin, it’s recommended to use scaling such as rem

    If there’s still any problem I recommended you watch Kevin Powell on youtube, the channel will help you a lot on your coding journey, other than that good job on finishing the challenge and happy coding 😁!!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord