Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Compenent using HTML CSS and Flexbox

@idlehands1969

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I found this challenge fairly simple once I finally wrapped my head around flexbox (thanks to @themegazord here on frontendmentor.io and YouTuber Kevin Powell's Flexbox videos). After that it was just a matter of styling the text and sizing the image.

Any constructive criticism is always welcome. I am always learning.

Community feedback

Lucas πŸ‘Ύβ€’ 104,540

@correlucas

Posted

πŸ‘ΎHello again Marta, congratulations for your new solution!

Your card is already really good, I've only some suggestions regardin the html code and the border-radius.

The border-radius has a strange aspect because you've used percentage, to have a perfect rounded border use instead px or rem. Try to replace in the container border-radius: 14px to see the difference.

About the html you can reduce a lot of the code removing unnecessary divs, all you need is a single <main> or <div> to keep all the content inside, and nothing more. The ideal structure is the div and only the image, heading and paragraph.

See the structure below:

<body>
<main>
<img>
<h1></h1>
<p></p>
</main>
</body>

πŸ‘ΎMy rating for this solution: ⭐⭐⭐⭐⭐

πŸ‘‹ I hope this helps you and happy coding!

Marked as helpful

0

@idlehands1969

Posted

@correlucas Thank you so much for the wonderful advice and the rating! Cheers!

1
P
Harm Intemannβ€’ 590

@ghintema

Posted

Hi Marta,

just reviewed your code and all I found is that there is a slight issue with the indentation :) Lines 20 to 30 need one more tab indentation. Right now, the div#box begins in the same column like the parent body. All the rest look neat and tidy to me! :)

Hope to have helped you, keep going and happy coding! :)

0

@idlehands1969

Posted

@ghintema Thank you!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord