Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

qr code componenet using html and css

Rodrigo Beckmann•20
@rodrigobeckmann
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


How i can do it better? not sure if this will work perfect in any situation.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Carlos Henrique•200
    @devriquesant
    Posted over 2 years ago

    Hello @rodrigobeckmann

    Congratulations for completing this challenge!!

    ✏️ Here are some tips and suggestions for this and your future projects ;) ✏️

    1. 🚀 Contain your "main" content in a "main" tag:

    • <main> is a semantic element from HTML which provides accessibility and organization for your web page;
    • semantic elements provides detailed info about the contents in your page.
    • Others semantic elements includes: <header>, <footer>, <figure>, <figcaption> ...
    • To implement this, you should exchange the <div class="main"> for <main> and wrap all the necessary and main content of your page

    2. 📱 Build a responsive web page:

    • Use px unit to dimension your components in the page makes it a appearance of static.
    • To build a more responsive one, you should start to use relative length units to adequate the page components to a device screen.
    • To deeper details, take a look at it

    3. 🌐 Build an accessible web page:

    • There are a lot of users of all kinds around the world! in order to make everyone able to use the program you just made you could provide some accessibility. But how?
    • The <img> tag has the alt property which helps screen readers to get all the content and info in your page.
    • It’s simple, just add an alt based on description of the image as: <img src=”cat.jpg” alt=”A cute cat”>

    Overall your project is great and keep coding, I'm sure you will discover new things and become even better

    Here, take a star for achieving it: 🌟 <- it's a glowing star if you're seeing a rectangle :)

    Marked as helpful
  • David Adenusi•370
    @Davidmide02
    Posted over 2 years ago

    Hi Rodrigo, you did a nice job but there is always room for improvement. Below are what you can Improve on:

    • your choice of html tags, always make use of the Semantics tags where appropriate. It make your code more readable just to mention but a few.
    • make sure your image tag always has alt.

    For the layout, you did a perfect job! keep building, it can only get better!

    If this is helpful you can hit the helpful button.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub