Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

First Frontend Mentor Challenge using HTML and CSS Flexbox

Karin Lee•50
@kleeblattdev
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


At the beginning I used fixed units for the section and img size (px). It looked good on the desktop version. After I changed the browser width to 576px (for the mobile version) I thought I could do the whole page to be responsive without doing much of changing the media queries, but it did not work as I expected it to be. I tried it with relative units (% and vw, vh), but then the desktop version did not look like how it should look.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,020
    @MelvinAguilar
    Posted over 2 years ago

    Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

    HTML:

    • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article.

    CSS:

    • Setting the width of the component with a percentage or a viewport unit will behave strangely on mobile devices or large screens. You should use a max-width of 320px or 20rem to make sure that the component will have a maximum width of 320px on any device, also remove the width property with a percentage value.
    • Setting a defined height for the card component is not recommended. The content should define the component height, otherwise, it will not be allowed to extend beyond your specifications. Alternatively, you can use min-height.
    main {
        background-color: hsl(212, 45%, 89%);
        /* height: 100vh; */ 
        min-height: 100vh; /* Use min-height insted of height*/
        display: flex;
        /* Add this to center the element instead of using margin: auto*/
        align-items: center;
        justify-content: center;
    }
    
    .qr-section {
        background-color: hsl(0, 0%, 100%);
        /* margin: auto; */
        /* width: 25%; */
        max-width: 20rem; /* Use a defined max-width*/
        margin: 1rem;   /* Add a margin to add some space for the container card and the screen edge on mobile devices*/
        /* height: 80%; */
        border-radius: 20px;
        /* padding-bottom: 10%; */
        padding-bottom: 1rem;
    }
    
    @media only screen and (max-width: 576px)
    .qr-section {
        /* width: 70%; */
    }
    

    I hope you find it useful! 😄 Above all, the solution you submitted is great!

    Happy coding!

    Marked as helpful
  • yanbabagbeto•70
    @yanbabagbeto
    Posted over 2 years ago

    Hi Karin. Congrats for completing the challenge. The overall solution is good. The only improvementn I will suggest is the space between the bottom border and the paragraph.

    Good job.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub