Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

QR code component

Danila•110
@ColdLikeMcFlurry
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


My first project :) I will be glad to any feedback

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Mohammad Ebrahimi•250
    @moheb2000
    Posted over 3 years ago

    Great job ❤️❤️

    1- title color is a bit lighter than black. You can use 'Dark blue' color for title. its value is in style-guide.md file.

    Good lock 👌👌👌

    Marked as helpful
  • Ali•270
    @aligjahed
    Posted over 3 years ago

    Hey man, Well done. I noticed some stuff that might help you become a better web developer. If you look close you'll notice that the design is quite thinner. To fix that problem and making sure the project looks close to the design you can use max-width for the whole card also I suggest using max-height for the QR code image which is taking way too much space. Hope this helps and good luck.👍

    Marked as helpful
  • Abdellah el aajjouri•190
    @abdellahelaajjouri
    Posted over 3 years ago

    You doing a great job body , your solution is amazing 👌 . Keep up

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub