Submitted
I HOPE YOU GUYS LIKE MY WORK , I THINK THERE SOMETHING THAT I MISSING
@aimal-qazi
Design comparison
Reports
All page content should be contained by landmarks
<div class="attribution">
Challenge by
<a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="#">Qazi Aimal</a>.
</div>Qazi Aimal’s questions for the community
Finally done it
Community feedback
@chrisjay358
Posted
Hi Qazi Aimal, you did fine work, congrats on that.
- My contribution is that you should add a margin-bottom to the container class in order to give a visual hierarchy to the attribution class.
- You can also use an
<article> instead of a <div>for semantics
Above that, it is great work you go there, keep doing you.
Marked as helpful
1
@aimal-qazi
Posted
@chrisjay358 Thanks for the information and feedback
0
@aa1659
Posted
Pls how do I submit my work.
0
@aimal-qazi
Posted
@aa1659 Go to your profile and then click on submit solution in the submit solution tab select your challenge and submit it I hope this will solve your problem
0
@aa1659
Posted
@aimal-qazi Thanks very much!
0
Hey!
Great job on this challenge :-)
If you want to take it a step further have a look at the feedback given on the accessibility report, there a couple of small changes you could make to the HTML to improve accessibility. The links are super useful, but if in doubt you can always look at other solutions (like mine) and see how it differs from yours and consider any changes you would make.
Well done!
0
@aimal-qazi
Posted
@lawlawson Thanks for the feedback
0
Please log in to post a comment
Log in with GitHub
Join our Slack community
Join over 180,000 people taking the challenges, talking about their code, helping each other, and chatting about all things front-end!