Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

QR Code Component

Aarón Jiménez•50
@Vonka-hub
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I used text-align to center most of my divs, i feel like this is not a good solution to my layout problems, would like to know if this is bad practice.

As always, im open to any feedback. Thank you in advance for any criticism given.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Ivan Olmo•310
    @ivanolmo
    Posted over 3 years ago

    You can center your main card very easily using flexbox. For example, you have text-align on your body, but that should only be used to align text, not elements/containers. You don't necessarily need the margin-top on your .container either. Instead you can do:

    body {
      display: flex;
      justify-content: center; /* this will center the card horizontally */
      align-items: center; /* this will center the card vertically */
    }
    

    You can do similar code with your .container to center your img and main div, and also with your .text-box to center your h2 and p, like this:

    .container,
    .text-box {
      display: flex;
      flex-direction: column;
      align-items: center; /* this will align your flex items (img and div) horizontally inside your card */
    }
      
    

    The vertical spacing between elements on your card can be accomplished with flex gap or with margins. For example, your .text-box has a margin-top of 30px, and that works to space it from your img, but the same can be accomplished by setting gap: 30px if your .text-box was a flex container.

    You'd only want to use text-align to center align your actual text within it's containing element, such as the text inside your h2 and p.

    Here is how I'd change your CSS, with comments:

    * {
            margin: 0;
            padding: 0;
          }
          body {
            background-color: hsl(212, 45%, 89%);
            /* text-align: center; <--- remove this */
            display: flex;
            justify-content: center;
            align-items: center;
            min-height: 100vh; /* add this so body will take up the entire viewport */
          }
    
          .container {
            /* display: inline-block;  <--- remove this */
            display: flex;
            flex-direction: column; /* the card flows vertically, so use column */
            align-items: center; /* will center img and .text-box horizontally */
            background-color: #fff;
            padding: 20px;
            font-family: 'Outfit', sans-serif;
            padding-bottom: 40px;
            /* text-align: center;  <--- remove this, instead apply it to elements that have text inside */
            border-radius: 4%;
            box-shadow: 3px 3px 20px 2px rgba(0, 0, 0, 0.1);
            /* margin-top: 50px;  <--- remove this, flex will position the card */
          }
    
          .container img {
            border-radius: 4%;
            width: 325px;
          }
    
          .text-box {
            margin-top: 30px; /* <--- doesn't necessarily have to be removed, but you can use flex gap on the parent container instead */
            /* text-align: center;  <--- remove this, instead apply it to elements that have text inside */
            display: flex;
            flex-direction: column;
            align-items: center;
            gap: 20px; /* instead of giving your h2 padding-bottom, give the flex container 20px gap instead to accomplish the same thing */
          }
    
          /* h2 and p are now centered by flex box */
          .text-box h2 {
            /* padding-bottom: 20px;  <--- remove this, replaced with gap above */
            text-align: none; /* now add this to center the text within it's own container */
          }
    
          .text-box p {
            color: hsl(220, 15%, 55%);
            font-size: 15px;
            text-align: center; /* now add this to center the text within it's own container */
          }
    
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub