QR code component using html and css

Hello @Bonker009, nice start, you did a great first challenge, now you need only to fix the alignment, see the tip bellow:

Try this to align the card to the center, basically the min-height:100vh will make the body have the screen size and make the rest of the content to align to that. A great resource to learn flexbox and manage these kind of alignment is this website, you can access here: FLEXBOX GUIDE - https://css-tricks.com/snippets/css/a-guide-to-flexbox/

body {
    min-height: 100vh;
    display: flex;
    align-items: center;
    justify-content: center;
    flex-direction: column;
}

Keep it up =)

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

• I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

• This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

• So fix it by replacing the <div id="container"> element with the semantic element <main> along with <div class="attribution"> into a <footer> in your index.html file to improve accessibility and organization of your page.

• What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

• They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

HEADINGS ⚠️:

• And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

• Every site must want at least one h1 element identifying and describing the main content of the page.

• An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

• So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

CSS 🎨:

• let me explain, How you can easily center the component.

• We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

• To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

• For this demonstration we use css Grid to center the component

body {
    min-height: 100vh;
    display: grid;
    place-items: center;
    margin: 0;
}

• Now remove these styles, after removing you can able to see the changes

#container {
  margin-right: auto; 
  margin-left: auto;
}

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!