Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

QR code component

JonDoesFrontEnd•30
@JonDoesFrontEnd
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm proud of that I made something with css, and that I used figma for the first time.

What challenges did you encounter, and how did you overcome them?

The body element not filling the entire sceen. I solved that by setting the height of the body to 100vh.

I can see now that the I probably didn't account for the padding when setting the box size...

Also - working with fonts I find a bit difficult.

What specific areas of your project would you like help with?

I'd love some feedback about best-practices, especially when it comes to css!

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • ricardoychino•190
    @ricardoychino
    Posted about 1 year ago

    Hi, great job with the solution.

    I just wanted to leave some tips:

    • Instead of fixing the height of body to 100vh, is better to set the min-height to 100vh. This makes the layout more dynamic and kind of ready for future changes
    • You can use line-height with 1.4 instead of 140%, for example. Not exactly a best-practice, but is more common this way and it is a bit cleaner
    • Inside a flexbox, margins "pushes" spaces as possible, so to center .card-container inside body, you could:
    body {
      display: flex;
    }
    .card-container {
      margin: auto; /* This pushes spaces in all four directions and centers the element inside the parent */
    }
    
    • This is something I personally think is a better practice, but nothing wrong if you don't want to: using box-sizing: border-box in whole stylesheet
    Marked as helpful
  • Ifehj•40
    @Ifehj
    Posted about 1 year ago

    looks pretty good on various screen types.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub