Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Semantic HTML5 markup CSS custom properties Flexbox CSS Grid Mobile-fi

@lucassantosdl

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@rostyslav-nazarenko

Posted

Hi! Cool code!

I have a few suggestions.

  • HTML
    • use main element for accessibility. Change <div class="container">...</div> to <main class="container">...</main>
    • alt attribute should describe an image or its function. Don't use the word image because screen readers read the tag as "image". In this case use QR code to frontendmentor.io. Read this article for more information
    • use h1 instead of h2, don't skip levels
  • CSS
    • use relative units to make your solution accessible
    • set max-width: 100% on images

Hope I've been helpful!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord