Submitted almost 3 years ago

QR code component

Shalom Quek•70

@atomz520

A solution to the QR code component challenge

Preview Code

Solution retrospective

Used Flexbox for Card positioning, and Grid for elements in the card.

Code

Couldn’t fetch repository

Please log in to post a comment

Community feedback

Melvin Aguilar 🧑🏻‍💻•61,020
@MelvinAguilar
Posted almost 3 years ago
Hi @atomz520 👋, good job on completing this challenge! 🎉

I like this solution for the challenge. Here are a few suggestions I've made that you can consider in the future if you're looking to improve the solution further:
- Try to use semantic tags in your code. Click here for more information.:
With semantic tags:
```
<body>
   <main class="container">
      <article class="card">
         . . .
      </article>
   </main>
<body>
```
- Add an h1 tag to your solution. The <h1> element is the main heading on a web page. There should only be one <h1> tag per page, and always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>). The HTML Section Heading elements (Reference)
Solution:
```
<h1>Improve your front-end skills by building projects</h1>
```
- Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
I hope those tips will help you.

Good job, and happy coding!
Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord