Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive CSS

@reanderagulto

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Hassia Issah 50,810

@Hassiai

Posted

Replace <div class="main"> with the main tag and <h2> with <h1> to fix the accessibility issue. click here for more on web-accessibility and semantic html

The body has a wrong background color.

For a responsive content which won't require a media query for this challenge, replace the width of .main-container with max-width and give it a fixed value. eg: max-width: 320px. Give the img a max-width of 100%.

Give p and h1 the same margin-left, margin-right and margin-top values. give p a margin -bottom value. h1, p{margin: 0 15px; margin-top: 15px} p{margin-bottom: 15px;}.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

0

@reanderagulto

Posted

@Hassiai Thanks for the suggestions! Highly appreciated

0

@reanderagulto

Posted

@Hassiai updated the solution with your suggestions. Thanks!

0

@MohmedElshaarawy

Posted

Hi Reabder Agulto Good job on completing the challenge !

I have some suggestions about your code that might interest you.

HTML

Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page. Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information. Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io CSS

Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here . Use min-height: 100vh instead of height: 100vh. The height property will not work if the content of the page grows beyond the height of the viewport. I hope you find it useful!

Happy coding❤️

0

@reanderagulto

Posted

@MohmedElshaarawy Thanks for the suggestions, highly appreciated!

0

@reanderagulto

Posted

@MohmedElshaarawy Updated the solution with your suggestions.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord