QR Code Component

Community feedback

• 

  Hassia Issah•50,410

  @Hassiai

  Posted over 2 years ago

  Replace <section class="container"> with the main tag, <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .container on the page using flexbox, replace the height in the body with min-height: 100vh.

  Give the img a max-width of 100% instead of a width. Reduce the max-width of .container for it to be equivalent to the design. max-width: 320px

  Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  00
• 

  Josh•1,120

  @josh76543210

  Posted over 2 years ago

  Great job on your solution! Looks Good!

  Here is a recommendation for improving your code:

  Use relative units like em or rem for the font-size instead of using pixels. The font-size in absolute units like pixels does not scale with the user's browser settings.

  I hope you find this useful!

  Happy coding!

  00