Looking to hire developers?
I would like to get the feedback for how i write the code for this challenge.
@NaveenGumaste
Posted
Hello Akadzani ! Congo 👏 on completing this challenge
Let's look at some of your issues, shall we:
<body>
<main class="container">
*all you content here*
</main>
</body>
happy Coding😀
Marked as helpful
@Akadzani
Posted
@Crazimonk Hello Naveen, thank you for the helpful feedback.
@Li-Bee
Posted
Pretty close to the design - well done 👏. Compared to the design i think you need to make the heading smaller and add a bit of space between the bottom of the paragraph and the bottom of the card.
To fix your accessibility issues you need to add <main></main> to your html - to add a landmark.
<body>
<main>
<div class="qr-code container">
....
</div>
<div class="attribution">
</div>
</main>
</body>
Marked as helpful
@Akadzani
Posted
@Li-Bee Hello Li-Bee, thank you for the feedback, it's really helpful.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
