Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

@NIk22517

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

romila 3,570

@romila2003

Posted

Hi Nikhil,

Congratulations 🎉 for completing this challenge, the card looks great. It is great that you used the flex property to center the card. I have some suggestions I want to address:

  1. Even though, you used the correct semantic for the main body, you should also wrap the footer within the footer tag which should be nested within the body and outside of the main tag e.g. <footer class="attribution"></footer>
  2. The texts are missing the font-family and color property. The p tag's color is quite quite light and in the original design, it is gray.
  3. I would recommend you giving the background-color property to the body instead of the main tag, as the body will cover everything however the container will only cover the container.

Overall, great attempt and wish you the best for your future projects so keep coding 👍.

Marked as helpful

0

@NIk22517

Posted

@romila2003 Thank you for the positive feedback! It means a lot to know you've noticed

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord