QR code component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,020

  @MelvinAguilar

  Posted almost 3 years ago

  Hi @Eleansphere, good job for completing this challenge! 👋

  This is a very good solution for this challenge but here are some suggestions to improve your code:

  • Don't use <br>, the <br> tag is not semantic. It should never be used to add vertical spacing, it is only used in specific cases (e.g. poem or an address) also when a screen reader reads the text it will break the text at the <br /> tag and break the flow of reading, You could use padding or margin styling via CSS to avoid them. More Information here.

  • Instead of using px in font-size, use relative units of measure like rem or em. Font size in absolute length units (px) does not allow a user with limited vision to change the text size in some browsers. Reference.

  • You could use use a CSS Reset to remove browser built-in styles and reduce browser inconsistencies

  /* This is very simple to reset the styles */
  * {
      box-sizing: border-box;
      margin: 0;
      padding: 0;
  }
  

  Popular reset style sheets:

  • A modern alternative to CSS resets
  • CSS Tools: Reset CSS
  • Custom CSS Reset

  I hope those tips will help you.

  Good Job !

  00

  Marked as helpful