Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 6 months ago

QR code component

Abhay Ghorela•60
@AbhayGhorela
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I believed that in this section, I would learn the proper technique to use CSS by storing the colors using css variables and root properties. ''' :root { --white: hsl(0, 0%, 100%); --slate300: hsl(212, 45%, 89%); --slate500: hsl(216, 15%, 48%); --slate900: hsl(218, 44%, 22%); } ''' ''' p { font-size: 15px; color: var(--slate500); font-weight: 400; padding: 0.2rem 0.5rem; } '''

What challenges did you encounter, and how did you overcome them?

This assignment helps me recollect my CSS abilities. I had a couple months of not using pure CSS.

What specific areas of your project would you like help with?

If someone has a better answer than me, please tell me where I can improve my code. I would like to gain input, which will help me develop my skills.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Kamran Kiani•2,780
    @kaamiik
    Posted 6 months ago
    • Add a separate file for your CSS styles.

    • Wrap all your contents in a main and the .attribution inside a footer.

    • No need for width: 100%; and max-width: 1440px;. There are pointless.

    • Use min-height: 100vh; instead of height:100vh;. height: 100vh strictly limits the height to the viewport size, potentially causing overflow issues if the content is larger than the viewport. On the other hand, min-height: 100vh allows your element to grow in height if the content exceeds the viewport size.

    • Your img only needs a max-width: 100%; and nothing else.

    • Try to use a proper CSS reset at the start of your CSS style. Andy Bell and Josh Comeau both have a good one. You can simply search on the internet to find them.
    Marked as helpful
  • Mahmoud-AbdelKarim•600
    @Mahmoud-Abdelkarim777
    Posted 6 months ago
    • For a good user experience, remove the max-width: 1440px; from body
    Marked as helpful
  • Michał Pawlak•180
    @MichalPawlak0
    Posted 6 months ago

    Looking good, nice job. Not much to complain about.

    I noticed that you added max-width on body tag which could be problematic (check out what happens on screens larger than 1440px using dev tools) - usually what we tend to do when we want to keep all content within a certain width limit is we put all the content inside a separate element (eg. div). We then add max-width and margin: 0 auto (to keep it centered). But not on the body element itself.

    Also, the image alt property seems to be missing a value.

    Good use of border-radius, margins, and box-shadow.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub