Frontend Mentor - QR code component solution

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,020

  @MelvinAguilar

  Posted over 2 years ago

  Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

  HTML:

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  • You must use a level-one heading (h1) even though this is not a full-page challenge. You can create an '<h1>' element within your 'main' element that will be hidden visually but visible and readable by screen readers. The class "sr-only" hides content visually and here are the styles to copy. e.g.: <h1 class="sr-only">QR Card Component</h1>

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  CSS:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.

  • Centering an element with position: absolute would make your element behave strangely on some screen sizes, "there's a chance the content will grow to overflow the parent". You can use Flexbox or Grid to center your element. You can read more about centering in CSS here.

  .container {
      /*width: 100vw;*/
      /*height: 100vh;*/
      min-height: 100vh;
      display: grid;
      place-content: center;
  } 
  
  .qrcode-card {
      /* margin: auto; */
      /* position: relative; */
      /* top: 50%; */
      /* transform: translateY(-50%); */
     . . .
  }
  
  .qrcode-image {
      width: 100%;
      /* height: 100%; */ /* Use this property when there is a containing div with a defined height, otherwise it will take the full height of the component */
      border-radius: 5%;
  }
  

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  11

  Marked as helpful