QR-code component

Community feedback

• 

  Yohans Hailu kasaw•10

  @yohans-kasaw

  Posted about 2 months ago

  change the font size of the first text. it way bigger than the design. there is also padding needed, at the bottom. add shadow, a little. the color or the opacity of the second text should also be similar to the desgin.

  11
• 

  Kasra Parhun•160

  @kasra6

  Posted about 2 months ago

  Hey buddy, A few comments from me :)

  Visual:

  • Of course the size is way different than original one
  • A different font has been used
  • Probably better to add the paragraph text into two <p> tags, so it would be in 2-3 lines as design
  • Border-radius seems to be less than original design

  Code:

  • I think it's completely not semantic. Of course it doesn't have to be, but better to write semantic code so basically it's a qr code card. Therefore, imho it'll be used inside another page, it's a component. So you could move your code inside <header> to <main> tag and get rid of header.

  • img 'alt' attribute value is incorrect. As you know, Alt should be something meaningful, if the image doesn't load it will load. Maybe better to leave it empty than adding an inappropriate value

  Cool! Nice job! Keep showing new works :)

  00
• 

  Marzia Jalili•7,270

  @MarziaJalili

  Posted about 2 months ago

  Nice and neat! 💯

  ✅ I would say...there wasn't a dire need to put the img in the header element, bro. Because it is still a part of the card. The same applies to the attribution section within the footer.

  ✅ You could move both of them back to the main element to make life easier.

  Other than that, you know your work, buddy!

  😎😎😎

  00