Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component | Dani Feelshot

#accessibility#sass/scss

@Feelshot

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I have done the exercise again, taking into account variables such as the use of sass and best practices in html.

Community feedback

@caarlosdamian

Posted

Hola Dani Felicidades por tu solucion espero ayudar con mis comentarios , usar scss excelente me encanto ese detalle

  1. Utiliza en tu reset de *{} box-sizing:border-box esto ayudara a que el padding y el contenido se sume para tener medidas mas exactas , puedes ver que tu card es un poco mas grande a la del diseno original. Puedes ver mas al respecto en box-sizing
  2. Puedes borrar <header></header> si no tiene contenido no hay problema.

Aun asi EXCELENTE TRABAJO sigue asi !

Marked as helpful

2

@Feelshot

Posted

@caarlosdamian Hola Carlos, gracias por tus comentarios, me son de mucha ayuda, lo implementaré en este y futuros ejercicios 🤩

0
Divine Obeten 2,435

@Deevyn9

Posted

Hi Dani, congrats on completing this project, your solution looks really good, however, you'll need to use max-width instead of width to make the container more responsive for smaller screens, you'll also need to add paddings to the left and right of the body to give it a bit of space from the container when it goes below the specified max-width.

I hope this is helpful to you.

Happy Coding!🎉

Marked as helpful

1

@Feelshot

Posted

Hello @Deevyn9 thank you very much for your comments, it certainly helps me to have a different perspective, I will implement it without a doubt.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord