Qr code component

Community feedback

• 

  Agnik Bakshi•480

  @Agnik7

  Posted over 2 years ago

  Hi, Congratulations on completing this challenge. I have some suggestions, which I think will help improve your skill.

  • For the footer text, use the footer tag instead of div.
  • Wrap all the content inside the body tag, except the footer tag, in main tag.
  • Replace the h2 tag with an h1 tag. This will get rid of the accessibility issue.
  • The image can't be viewed, because the code doesn't know where to search for the images folder. To fix that, add a ./ at the start of the source of the img tag.

  Replace 
  <img src="images/image-qr-code.png" alt="Qr">
  
  with
  
  <img src="./images/image-qr-code.png" alt="Qr">
  

  • For the container, instead of specifying the width, specify only the max-width. This will help achieve responsiveness, and you will also not need the media query.

  Hope this feedback helps you.

  Have a nice day!!

  00
• 

  re:shono•10

  @giorgishonia

  Posted over 2 years ago

  Im not the one to judge but what's this

  00