QR code component

Community feedback

• 

  Agnik Bakshi•480

  @Agnik7

  Posted over 2 years ago

  Hi, Congratulations on solving this challenge!!🎉🎉🎉🎉. Your solution was very good. However, I have some suggestions that might help you.

  • Provide the required background color to the body, referring to the style-guide.md file.
  • Replace the final div tag with a footer tag, as it is supposed to be the footer element of the page. Also, a blank space has accidentally been added to the target="_blank".

  Replace
  <div class="attribution">
      Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.
      Coded by <a href="https://anik-das-portfolio.netlify.app/" target="_blank    ">Anik Das</a>.
    </div>
  
  with
  
  <footer class="attribution">
      Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.
      Coded by <a href="https://anik-das-portfolio.netlify.app/" target="_blank">Anik Das</a>.
    </footer>
  

  • Instead of using h6 tag, use h1 tag. This way, you won't have to alter the font size that much.

  • Wrap the whole code inside body but just before the footer, inside a main tag, to get rid of the accessibility issue Document should have one main landmark.

  Hope this comment helps you. Please feel free to correct me if you said anything incorrect.

  Have a nice day!!!

  11

  Marked as helpful