Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component using HTML & CSS

#bem#accessibility
Lawrenceโ€ข 180

@lawlawson

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

Producing this pixel-perfect development without designs.

What challenges did you encounter, and how did you overcome them?

This was fairly straightforward however, the most interesting aspect was aligning the design in the middle of the page.

What specific areas of your project would you like help with?

None

Community feedback

@MelvinAguilar

Posted

Hello there ๐Ÿ‘‹. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

HTML ๐Ÿ“„:

  • In this challenge, the picture tag is not needed, since the image does not need to change depending on the viewport. This is necessary when the platform provides two images, one for mobile and one for desktop. You can directly use the image tag in this solution.

Alt text ๐Ÿ“ท:

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.
  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. ๐Ÿ“˜.

CSS ๐ŸŽจ:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here ๐Ÿ“˜.

I hope you find it useful! ๐Ÿ˜„ Above all, the solution you submitted is great!

Happy coding!

Marked as helpful

1

Lawrenceโ€ข 180

@lawlawson

Posted

@MelvinAguilar Wow, thank you so much for the detailed feedback, very kind of you! I'll be sure to read the links you have sent to me and implement the suggested changes to further my understanding.

0
Hassia Issahโ€ข 50,810

@Hassiai

Posted

To center .container on the page using flexbox, replace the height in the body with min-height: 100vh.

give the img a max-width of 100% instead a width and height value.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

0

Lawrenceโ€ข 180

@lawlawson

Posted

@Hassiai thank you for the feedback and sharing the link to the video, super helpful in my learning journey.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord