Skip to content
Submitted over 3 years ago

QR Code Component

Adam Elitzur•110
@AdamElitzur
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Is there anything that I should be doing differently? Maybe with the units, is it bad to hardcode in 25 ems just because it looks right?

Code

Please log in to post a comment

Log in

Community feedback

  • Naveen Gumaste•10,420
    @NaveenGumaste

    Hay ! Adam Good Job on challenge

    These below mentioned tricks will help you remove any Accessibility Issues

    -> Add Main tag after body <main class="container"></main>

    -> Learn more on accessibility issues

    If this comment helps you then pls mark it as helpful!

    Have a good day and keep coding 👍!

    Marked as helpful
  • P
    Jessica•880
    @perezjprz19

    So your image is actually huge on my phone and I think that is because you hard coded the width and the height, so it's not adjusting to my screen size and it's overflowing.

    Could you try playing around with max-width instead of width?

    I also didn't add a height to mine. I let the content in the card decide the height.

    Here is my solution in case you want to check it out.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord