Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

@alexpenadev

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison

SolutionDesign

Reports

Accessibility report (1)
warning

Page should contain a level-one heading

<html lang="en">
Learn more

Alexander Pena’s questions for the community

Let me know if anything can be improved. I am just returning to frontend mentor after a long break.

Community feedback

Chris Jay 220

@chrisjay358

Posted

Hi Alexander, I think you did a good job, and if you want to make it even better, here are my observations that you can add.

  • The color of the <p> text.
.qr-body p {
  color: var(--gray-blue);
}
  • You could also have used
<article class ="container"></article> instead of <div class ="container">

It is better for semantics and helps screen readers also.

  • You can reduce the padding on the inside also.

Above all this I called out, you did a pretty amazing job considering you've been off for a while. Keep winning and growing Alexander Pena!

Marked as helpful

1

7milkyways 100

@7milkyways

Posted

you did a really wonderful job, just follow the style guide as previously mentioned

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Slack logo

Join our Slack community

Join over 180,000 people taking the challenges, talking about their code, helping each other, and chatting about all things front-end!