Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 5 months ago

QR Code Component

P
Andrew A Lee•380
@drewlee
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I was pleasantly surprised at the ease that CSS Flexbox allows for laying out elements. I transitioned away from web development right around the time when Flexbox and Grid were becoming standardized. I'm mostly familiar with the excruciating pain points and hacks we web developers endured before these modern layout techniques were available. I'm glad those are now a past relic and am proud of having learned how to leverage Flexbox sufficiently. I'm still in the process of catching up with modern CSS methodologies and would incorporate more of these best practices on my next project.

What challenges did you encounter, and how did you overcome them?

The biggest pain points were encountered with setting up the project with NPM and Github. I wanted sufficient safeguards for my projects and have included Prettier, ESLint, and Stylelint for HTML, CSS, and JS checks. In particular, the ESLint configuration setup has recently changed to a "flat" configuration, which took some time to determine the optimal setup for. I overcame the issues mostly with trial and error and by inspecting the config objects as well as by leveraging the CLI --inspect-config tool.

What specific areas of your project would you like help with?

Mostly ensuring that I am following modern conventions and best practices for authoring HTML and CSS code.

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • AMaraza•40
    @AMaraza
    Posted 5 months ago

    Overall this is a very clean and accurate result with not much to critique.

    I might suggest using more combinators within your style sheet instead of relying solely on class elements.

    For example: .qr-card-container p would target every paragraph within your qr card container. Or you could write .qr-card-container .qr-card-caption to specifically target everything with the class qr-card-caption within qr-card-container.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub