QR code component

Community feedback

• 

  Edlitamis•40

  @edlitamis

  Posted 6 months ago

  Here are some improvements suggestions regarding the index.html file:

  • l24-26: you don't need to put the <img> tag within a <div> tag. The <img> tag is its own object in the sense that you can target it as is in you CSS file (you're doing it when targeting qr-image). Actually if you check the CSS file, the image class is never called or used, proof that it's useless.
  • l28: you have an <h2> but no <h1>. A good practice is to not skip heading levels: always start from <h1>, followed by <h2> and so on (check HTML heading documentation for more info).

  Code improvements in the qrcode.css file:

  • The CSS style file naming convention is styles.css.
  • l59-61: I think you can add padding to the container element so that the top doesn't crop when you shrink the screen size. Your updated code would then look like this:

      .container {
          width: 90%;
          height: auto;
          padding: 20px;
      }
  

  Apart from that I would say the code is good and readable and your solution looks like the design solution, keep it up 💪

  I am not an expert myself but I hope it helps 😊

  01

  Marked as helpful
• 

  NossPro•30

  @NossPro

  Posted 6 months ago

  La sementique HTML est correctement respecter elle est accesible oui je trouve que certaine ligne de code n'ont pas lieu d'être ça charge pour rien le code oui la mise en page ça va oui pour les trois non je ne pense pas

  00
• 

  Sawmail•10

  @shamel-rai

  Posted 6 months ago

  Great Work

  00