Skip to content
Submitted about 2 years ago

QR code component

Aisha Mohammed•30
@Scazee
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

This is my first challenge, it was nice. It took me a while to center the qr code container's container though, cause I set the height to 100% instead of 100vh. Any comment will be helpful, thank you.

Code
Couldn’t fetch repository

Please log in to post a comment

Log in

Community feedback

  • Abdul Khaliq 🚀•72,380
    @0xabdulkhaliq

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    QR iMAGE ALT TEXT 📸:

    • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.
    • The alt with qr-code img is not even explaining for what the QR image need to be used.
    • So update the alt with meaningful text which explains like QR code to frontendmentor.io
    • Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
  • Jonah Ssegawa•240
    @devjhex

    Hello @Scazee, you have done a really great job with this solution. Thanks for putting in the effort until it's completed. Hope these suggestions will help in your solutions too! In your code, I think it's better to use tags that are more accessible like <section> and <article> which increases its availability to your audience.

         <section class="flex-container"> instead of <div class="flex-container">   
     <article class="qr-container"> instead of <div class="qr-container">

    This makes it accessible to screen readers hence so that they know what the elements mean Hope this helps, otherwise Great solution and Keep it up!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord