QR code submission

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,020

  @MelvinAguilar

  Posted over 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • Change the name of the file qrcode.html to index.html to access the solution only using https://cyclone3603.github.io/qr-code-component-main/. by default when typing a url the file index.html is displayed and that's why you had to manually write the file name.

  HTML 📄:

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  • Always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>).

  CSS 🎨:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. You can read more about this here 📘.

  • Use min-height: 100vh instead of height: 100vh. The height property will not work if the content of the page grows beyond the height of the viewport.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  03

  Marked as helpful
• 

  Ansly•290

  @Median21

  Posted over 2 years ago

  Hello there! You did a good job following the designs and completing the challenge 😀

  Here are the problems I would like to address:

  - Don't start your code by putting it in a <div> even though it is still acceptable, since this challenge only requires one content, it is still a good practice to use semantic elements like <header>, <main>, and many more. So that it is easier to be seen in search engines and makes it more specific.

  - The <br> tag is not a semantic element. If a screen reader user is reading the page, they will hear "line break", which breaks the flow of the content. Instead, use CSS properties like margin and padding to add vertical space between elements. (I got this tip from a feedback, so I also wanted it to share to you)

  Overall, you did a very good job! Knowing that you just came back from coding 💪

  11