Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component - By harderth

backpackoderβ€’ 80

@MrFougasse

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


My first challenge. Here it is.

Community feedback

Erayβ€’ 1,410

@ErayBarslan

Posted

Hey there, congrats on your first solution! Design looks really close to the provided. My suggestions:

  • Instead of fixed width you can use max-width to make the page responsive. by default width: auto which is responsive. As it is, on small screens content overflows.
  • Unless you really need to, don't give height to your elements. Let the width,margin,padding define their height so you won't run into any issues. I've done some refactor to make the page responsive:
    .wrapQR {
      background-color: hsl(0, 0%, 100%);
      max-width: 300px;
      padding: 0 10px 30px 10px;
      border: solid #fff;
      border-radius: 15px;
      margin: auto;
    }
    .QR {
      width: 100%;
      border-radius: 15px;
      margin: 10px auto;
    }

You can keep the rest of styling as it is. With these changes, base design is the same but when screen gets smaller there is no overflowing issue that is due to max-width. Also since your page is deployed now, you can use generate new screenshot option to see how close you are on your design. Hope these helps, happy coding :)

Marked as helpful

1

backpackoderβ€’ 80

@MrFougasse

Posted

@ErayBarslan I checked it up and yeah, I still have problems with the responsive when I code, so thank's so much for your tip!

0
Bandaru Sindhujaβ€’ 190

@SindhujaBandaru

Posted

Hello @MrFougasse I think you didn't uploaded the entire folder in github.Try uploading Images,design,Readme files in your github repository.Then we can see the design maybe.Its showing 404 error.

Marked as helpful

0

backpackoderβ€’ 80

@MrFougasse

Posted

@SindhujaBandaru Hello, I just modified the "Preview site", please check here : https://challenges.challenges-b93.pages.dev

0
Bandaru Sindhujaβ€’ 190

@SindhujaBandaru

Posted

@MrFougasse I have seen it.Amazing WorkπŸ‘

Marked as helpful

0
backpackoderβ€’ 80

@MrFougasse

Posted

@SindhujaBandaru Thank you, I am gonna take a look on the challenges you did too!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord