Skip to content
Submitted over 1 year ago

QR code component card

Rabel•190
@Rabelahmed
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

if you think i could have something differently or bettter plz let me know

Code

Please log in to post a comment

Log in

Community feedback

  • Brendan•1,120
    @OneManBanned

    Hi Rabel, I have a few suggestions for you.

    • The <h3> tag should be a <h1>. Every page needs a <h1> and the heading elements (<h1><h2><h3><h4><h5><h6>) must be used in ascending order. Here is the mdn page on heading elements

    CSS

    • If you remove the margin declarations from .card and the width from main. Then add the following to main
    justify-content: center;
min-height: 100vh

    you will have it all nicely centered using flex-box :)

    • I suggest you look at using relative units instead of pixels. Have a look a rem, em, vh, vw and %. Here is a handy page that converts pixel vales into rem (link)

    Nice solution. Happy Coding

    Brendan.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord