Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 years ago

QR code component card

Oreoluwa Samuel Akinbo•100
@KingHorey
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


  1. I had issues with the margins and size of the divs. However, I used my discretion in creating one with the dimensions I felt were right

  2. When using the inspect tool in chrome and resizing the webpage, the paragraph element just out of the div and I do not know how to resolve that.

Here's the link to the image code below:

HTML code

   <div class="text">
      <h1>Improve your front-end skills by building projects</h1>
      <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
    </div>

CSS code

h1 {
    font-family: "Outfit";
    font-size: 17px;
    font-weight: 700;
    color: hsl(218, 44%, 22%);
}

.text {
    width: 80%;
    margin: 0 auto;
    height: auto;
    position: relative;
    bottom: 5;
    top: 4%;
    word-wrap: break-word;
}

p {
    height: inherit;
    font-family: "Outfit";
    font-size: 15px;
    color: hsl(220, 15%, 55%);
    font-weight: 500;
}

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Vanza Setia•27,715
    @vanzasetia
    Posted about 2 years ago

    Hi, Oreoluwa Samuel Akinbo! 👋

    The card is not responsive because you set width and height to most of the elements. You must not do that. You should remove them.

    You only need to set a max-width to the card element. This allows the card to shrink if ever needed and the card to grow until the specified value of the max-width. In short, the card will be responsive.

    Some other suggestions:

    • Use a CSS reset whenever you start a new project. This can help you set the styling foundation easily. My recommendation — A Modern CSS Reset | Andy Bell
    • To make the image not overflowing, you should make the <img> element a block element and set max-width: 100%.
    • Remove <div class="image-div"> and <div class="text">. You do not need to wrap the QR code and the text with <div> elements.
    • Don't use relative positioning.

    I hope this helps. Happy coding! 👍

    Marked as helpful
  • Zsolt Varjú•490
    @zsoltvarju
    Posted about 2 years ago

    Hello Oreoluwa Samuel Akinbo!

    I checked/tried your code keep practicing and keep up the good work, congratulation to you for working on this project!

    Here are my suggestions:

    • As mentioned in Vanza Setias comment if you use max-width your .attribution container instantly becomes more responsive.
    • i would suggest that in the .image-div class you delete the margin-top and margin, instead use padding (1rem for example) This way you can make a nice white lane around the image.
    • Also in the same class you can remove the width and height because it will resize automatically according to its container size

    Please take my advice lightly, i am a beginner too and my advice is according to the best of my knowledge, i might be wrong.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub