@correlucas
Posted
👾Hi L N S S Ravi Teja, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!
Great start and great first solution! You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code:
1.Your html code is not optimized yet, since its too long and have some unnecessary elements. To make it clean you start by removing some unnecessary <div>
. For this solution you wrap everything inside a single block of content using <div>
or <main>
(better option for accessibility) and put inside the whole content <img>
/ <h1>
and <p>
.
<body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
<h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>
2.Replace the <div>
you’ve used to wrap the card container with <main>
, that in this case is the best tag and shows that this is the main block of content of this page.
3.It's even better to use relative units
as rem
or em
that have a better fit if you want your site more accessible between different screen sizes and devices. REM
and EM
does not just apply to font size, but to all sizes as well.
✌️ I hope this helps you and happy coding!
Marked as helpful