Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component with Simple HTML and CSS

Hania B. 1,360

@techanthere

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P

@ccreusat

Posted

Great job !! It's perfect and no report issues ;)

The only thing I would suggest is if you use BEM approach, change :

  • main__card-heading > main-card__heading

Usually, its :

  • .parent
  • .parent__children
  • .parent__children--modifier

:)

Marked as helpful

0

Hania B. 1,360

@techanthere

Posted

@ccreusat thanks for the suggestions, really appreciated! I didn't really start taking bem naming convention serious until now, but I think I should definitely consider it.

1
P

@ccreusat

Posted

@techanthere now you can :) nice job tho!

1

@Kamasah-Dickson

Posted

I really thinks its the margin top u added to the footer text that's why there is a slight deference between design and code....it also happened me...but actually I don't think it makes a difference... Good job there :)

1

Hania B. 1,360

@techanthere

Posted

@Kamasah-Dickson good job with that, feedback much appreciated!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord