Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

QR code component challenge

Tobias•100
@ToHX
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi everyone,

I'm not completely happy with my card-shadow. I did use a website (https://getcssscan.com/css-box-shadow-examples) for that but you can see that on the QR Code img it doesn't fit.

Apart from that, I was this time much faster in building my solution as this is my 2nd project. :)

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Abhik•4,820
    @abhik-b
    Posted over 3 years ago

    👋 Hello Tobias , Your solution is nice & responsive , Well Done 🤩

    However if you try the below mentioned suggestions your great solution can look greater :

    • to place the card at the center of the screen use the below code on body :
    display: flex;
    flex-direction: column;
     align-items: center;
     justify-content: center;
    
    • give max-width:330px (use px value according to your choice) so that card does not touch edges as mentioned by Jessica
    • I played with the box-shadow & increased the opacity & value of X, changed the value of Y & reduced the blur & I am happy with the final result rgb(17 12 46 / 25%) 12px 24px 48px 0px;

    Other than that nicely done & Please keep contributing amazing solutions like this 👍

    Marked as helpful
  • P
    Jessica•880
    @perezjprz19
    Posted over 3 years ago

    Hi ToHX!

    I think your shadow looks fine based on the challenge comparison. However, the card does touch the edges of my phone screen so I can't really see the shadow. Some margin could help with that.

    Marked as helpful
  • Naveen Gumaste•10,420
    @NaveenGumaste
    Posted over 3 years ago

    Hay ! Good Job Tobias

    Keep up the good work!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub