@MohmedElshaarawy
Posted
Good job my friend, I wish you all the best ..๐ฅโค๏ธ
Marked as helpful
@mohammad-kawach
Posted
@MohmedElshaarawy Thank you for the feedback. I appreciate that.
Looking to hire developers?
@MohmedElshaarawy
Posted
Good job my friend, I wish you all the best ..๐ฅโค๏ธ
Marked as helpful
@mohammad-kawach
Posted
@MohmedElshaarawy Thank you for the feedback. I appreciate that.
@MelvinAguilar
Posted
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML ๐:
<main>
tag to wrap all the main content of the page instead of the <div>
tag. With this semantic element you can improve the accessibility of your page.Alt text ๐ท:
alt
attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.The alt
attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt
attribute would be QR code to frontendmentor.io
If you want to learn more about the alt
attribute, you can read this article. ๐.
CSS ๐จ:
em
or rem
. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here ๐.I hope you find it useful! ๐
Happy coding!
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord