@MelvinAguilar
Posted
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML ๐:
Alt text ๐ท:
-
The
alt
attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a betteralt
attribute would beQR code to frontendmentor.io
If you want to learn more about the
alt
attribute, you can read this article. ๐.
CSS ๐จ:
- Instead of using pixels in font-size, use relative units like
em
orrem
. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here ๐.
- Use
max-width: 20rem
to.container
selector instead of width, this will make the container card a bit responsive on mobile and set the element's maximum width to 20rem.
- Update the image selector to make responsive images:
img {
width: 100%;
/* width: 20rem; */
/* height: 20rem; */
border-radius: 18px;
}
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@dxiDavid
Posted
@MelvinAguilar Thank you. I'll try to avoid absolute values as much as possible and be more descriptive with the alt tag in HTML. Thanks for the feedback