QR code component

Solution retrospective
This is my attempt to this challenge. Any feedback is welcome! Thanks!
Please log in to post a comment
Log in with GitHubCommunity feedback
- @AdrianoEscarabote
Hi David Iván Cabello, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
To improve the responsiveness of the project, we can do this:
.card { max-width: 350px; }
Document should have one main landmark, this problem is being caused by the fact that there is no main tag around the main content of the page! Since this challenge is based on only one component, there is no other component more important than it on this page, so to solve this, wrap all the content with the
main
tag,It's always good to pay attention to the correct use of semantic html elements, as they are extremely important for people who use screen readers, to know what the main content of the page is in the case of the
main
tag!The rest is great!
I hope it helps... 👍
Marked as helpful - @suhaybjirde
amazing 100% perfect it's not much for a little notice
your box shadow looks a bit much i think you should decrease it
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord