QR Code Component (Flexbox + BEM)

Solution retrospective
Hello there, I’m Akiraz 🐺
This solution really took me a while (longer than I expected), I wanted to do it myself but also review other people's code to make sure my approach was correct and my HTML and CSS code was clean, scalable and maintainable. It was a very fun and educational process.
Any feedback on how I can improve my coding skills is welcome!
Thank you. ✌️😎
Please log in to post a comment
Log in with GitHubCommunity feedback
- @dxiDavid
Hello there @Akiraz14 👋🏾
I have a suggestion that will help you write better code
- when setting custom properties, try giving them descriptive names like
--primary-font-color
instead of--color-1st
. It will make your CSS easier to read and understand. Also, try to set custom properties for styles such asfont-size
,font-weight
, (basically things you see in the style guide)border-radius
since they will most likely be used on more than one occasion. - Limit the use of pixels to things like
box-shadow
andborder-radius
, otherwise use relative units. - only look for references when you are absolutely stuck and cannot find a way out. don't waste time doubting yourself. If you have a working solution then good. come back and refactor later
The attention to detail in your solution is impressive💪🏾
Keep Going, happy coding🥂
Marked as helpful - when setting custom properties, try giving them descriptive names like
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord