QR Code Component

Community feedback

• 

  João Vitor•740

  @jvssvj

  Posted 3 months ago

  Hello friend, congratulations on completing the challenge 👏. I'll give you some tips, starting with HTML.

  📌 I saw that you placed a main tag, and then a div with the container class, this div is not necessary, because in this case the main tag would already be the container.

  📌 In your text class we can place a section, as it contains a main title.

  💡 Use BEM in your projects. Read more here: BEM

  Your Fixed HTML:

      <main class="container">
          <img src="images/image-qr-code.png" alt="QR Code image.">
         
          <section class="text">
              <h1 class="text-preset-1">Improve your front-end skills by building projects</h1>
              <p class="text-preset-2">Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
          </section>
      </main>
  

  📌 If the component needs to shrink according to the screen size, do not use fixed widths, this way you avoid some unnecessary styles. for example: width: 320px, opt for:

  .component {
     width: 100%; /*To occupy 100% of the available size*/
     max-width: 320px; /*adjust as needed*/
  }
  

  10

  Marked as helpful
• 

  ROKUROO7•90

  @ROKUROO7

  Posted 3 months ago

  Hello there, Good Job on Completing the challenge.

  As i am pretty new to web development, just started a few weeks ago. So i can’t really provide much of an insight on the other hand i really learned a lot from reading your code such as using min-content as width.

  Thanks.

  10