Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 4 months ago

QR Code Component

Jhanpiere Montes•50
@inkarrime
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

To use semantic HTML and I would add using grid-template-columns to make it more responsive if there is more than one card.

What challenges did you encounter, and how did you overcome them?

Units of measurenment and using the relative measure of rem.

What specific areas of your project would you like help with?

Have our semantic HTML evaluated.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Kuvashnee Naidoo•450
    @KuvashneeNaidoo
    Posted 4 months ago

    Hey Jhanpiere! Outstanding work on the QR Code Component! It adapts well across different screen sizes 🌟🙌🌟

    I have one suggestion in response to your question about having your semantic HTML evaluated:

    • Visit the The W3C Markup Validation Service and go to the "Validate by Direct Input" tab. Here, copy and paste your HTML in the empty input field and click the "Check" button. Your code will be evaluated for any syntax errors, missing tags, or incorrect usage of HTML elements, helping to ensure that your markup follows best practices and is fully compliant with web standards.

    • Based on your HTML which I tested, one warning was returned, namely: "Section lacks heading. Consider using h2-h6 elements to add identifying headings to all sections, or else use a div element instead for any cases where no heading is needed."

    • According to HTML best practices, each <section> element should have a heading (like <h2>, <h3>, etc.) because it provides context, improves accessibility, and helps search engines better understand and index the content.

    • However, in this case, since a heading is not required, you can change the <section> tag to a <div> tag because a <div> is a generic container with no semantic meaning, making it suitable when no specific section heading is needed.

    • For instance, you could modify your code like so:

        <main class="main">
          <div class="cards-container">
            <!-- The rest of your code -->
          </div>
        </main>
    
    Marked as helpful
  • Chris Spencer•30
    @TheRealSoulz61V
    Posted 4 months ago

    Looks really good. I don't have any feedback

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub