@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
Alt text 📷:
-
The
altattribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a betteraltattribute would beQR code to frontendmentor.ioIf you want to learn more about the
altattribute, you can read this article. 📘.
CSS 🎨:
- Setting the font-size to 62.5% can attract compatibility issues with third-party libraries or plugins. You can read more about this with this two lectures:
Credit to grace-snow and vanzasetia for pointing this out.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@rostyslav-nazarenko
Posted
@MelvinAguilar Hi! Thank you so much for the feedback and for providing resources!
Already implemented your suggestions 😊
The article about alt attribute really helped me. I never thought about it that way.
I'm not going to set font-size: 62.5% from now and will correct the same in the other challenge. I thought that it was a great trick to use. Doing the math without calculator in base of 16 is doable if only using units divided by 4. And here the body text 15px and because of that decided to use font-size: 62.5%
Thanks for your help. 😁 Have a great day!
