@MelvinAguilar
Posted
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML ๐:
- Use the
<main>
tag to wrap all the main content of the page instead of the<section>
tag. With this semantic element you can improve the accessibility of your page.
Alt text ๐ท:
- The
alt
attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.
-
The
alt
attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a betteralt
attribute would beQR code to frontendmentor.io
If you want to learn more about the
alt
attribute, you can read this article. ๐.
CSS ๐จ:
- Instead of using pixels in font-size, use relative units like
em
orrem
. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here ๐.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@garcialexco
Posted
@MelvinAguilar Thank you very much for your input! Honestly semantic HTML is a bit confusing for me and same with alt text, so I appreciate it!
Awesome, I'll be sure to use em
or rem
for font-size from now on.
Thank you again! ๐