QR Code Component | HTML & CSS

Solution retrospective
What areas did you struggle with while creating the project?
I didn't struggle much, but even though I set the container's size to (max-width: fit-content;), there were still spaces around it (img max-width:%50;). So, I limited it to 'em' and it worked. If you have any suggestions, please let me know!
Which parts of your code are you unsure about?
I don't think there's any part of the code I'm unsure about, but as I mentioned, I had a minor issue with the size of the container. Also, I'm still not an expert in tag usage :)
Please log in to post a comment
Log in with GitHubCommunity feedback
- P@danielmrz-dev
Hello @ArdaBozan!
Your solution looks great!
I have one suggestion:
📌 I noticed that you used 3 tags as wrappers (main, section and div) and also an
article
tag for the text.Unless you do it for a specific reason, there's no need for that many tags. They only make your code bigger, considering that's possible to achieve the same result with only one tag as a wrapper (
main
) and the content inside (img
,h1
,p
).Removing those unnecessary tags will make your code much cleaner and easier to read and maintain.
I hope it helps!
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord